templates/edge/[Content_Types].xml.tmpl - Issue 29345751: Issue 4028 - Add support for Edge extensions to buildtools

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Side by Side Diff: templates/edge/[Content_Types].xml.tmpl

Issue 29345751: Issue 4028 - Add support for Edge extensions to buildtools (Closed)

Patch Set: Address comments on patch set 1 Created June 17, 2016, 5:51 p.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 <?xml version="1.0" encoding="UTF-8"?>

	2 <Types xmlns="http://schemas.openxmlformats.org/package/2006/content-types">

	3 <Default Extension="json" ContentType="application/json"/>
	Sebastian Noack 2016/07/01 15:56:04 I wonder whether we should auto-generate the defau I wonder whether we should auto-generate the defaults based on the file extensions actually used in the bundle using the mimetypes module. Vasily Kuznetsov 2016/07/01 19:51:28 We could, but I thought it would be more work than Show quoted text On 2016/07/01 15:56:04, Sebastian Noack wrote: > I wonder whether we should auto-generate the defaults based on the file > extensions actually used in the bundle using the mimetypes module. We could, but I thought it would be more work than just using a static file. Sebastian Noack 2016/07/05 14:30:37 I don't have a strong opinion, but in the sense of Show quoted text On 2016/07/01 19:51:28, Vasily Kuznetsov wrote: > On 2016/07/01 15:56:04, Sebastian Noack wrote: > > I wonder whether we should auto-generate the defaults based on the file > > extensions actually used in the bundle using the mimetypes module. > > We could, but I thought it would be more work than just using a static file. I don't have a strong opinion, but in the sense of DRY adding a little more logic here would be better than maintaining a hardcoded/redundant list. Moreover, what if future builds add files with extensions not considered here? Vasily Kuznetsov 2016/07/07 16:23:48 I implemented your suggestion and now the content Show quoted text On 2016/07/05 14:30:37, Sebastian Noack wrote: > On 2016/07/01 19:51:28, Vasily Kuznetsov wrote: > > On 2016/07/01 15:56:04, Sebastian Noack wrote: > > > I wonder whether we should auto-generate the defaults based on the file > > > extensions actually used in the bundle using the mimetypes module. > > > > We could, but I thought it would be more work than just using a static file. > > I don't have a strong opinion, but in the sense of DRY adding a little more > logic here would be better than maintaining a hardcoded/redundant list. > Moreover, what if future builds add files with extensions not considered here? I implemented your suggestion and now the content type map is autogenerated. The template became a bit shorter but more complicated, and the function that uses it is now quite a bit longer. It might catch some extensions that were not hardcoded before though, so at least it's more robust this way. Done
	4 <Default Extension="html" ContentType="text/html"/>

	5 <Default Extension="js" ContentType="application/x-javascript"/>

	6 <Default Extension="png" ContentType="image/png"/>

	7 <Default Extension="css" ContentType="text/css"/>

	8 <Default Extension="gif" ContentType="image/gif"/>

	9 <Default Extension="otf" ContentType="application/octet-stream"/>

	10 <Default Extension="xml" ContentType="text/xml"/>

	11 <Override PartName="/AppxManifest.xml" ContentType="application/vnd.ms-appx.ma nifest+xml"/>

	12 <Override PartName="/AppxBlockMap.xml" ContentType="application/vnd.ms-appx.bl ockmap+xml"/>

	13 </Types>

OLD	NEW

« packager.py ('K') | « templates/edge/AppxManifest.xml.tmpl ('k') | templates/install.rdf.tmpl » ('j') | tests/AppManifest.xml.expect » ('J')